fixes virtual dep resolution for dynamically imported inline styles #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 76.53% 76.75% +0.21%
==========================================
Files 9 9
Lines 537 542 +5
Branches 120 121 +1
==========================================
+ Hits 411 416 +5
Misses 81 81
Partials 45 45
☔ View full report in Codecov by Sentry. |
|
not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
created a helper function to handle the slight differences between the ssr/dom virtual file resolution and the hydrate file resolution
Motivation and Context
Fixes an issue with a dynamically imported marko component's inline style. previously it would create a file name that wouldn't work (404)
Screenshots (if appropriate):
Checklist: